search

metosin / malli

High-performance data-driven data specification library for Clojure/Script.
Eclipse Public License 2.0
1.44k stars 204 forks source link

fix: -string->double for cljs shouldn't allow trailing garbage #942

Closed opqdonut closed 10 months ago

opqdonut commented 10 months ago

(js/parseFloat "1.2abba") ==> 1.2

This was a difference between clj and cljs behaviour, but didn't have a test.

Potentially a breaking change since somebody could've unknowingly relied on this.

opqdonut commented 10 months ago

Merging this despite the 1.10 vs 1.11 question. Tests don't pass currently on 1.10 anyway, see #943