metosin / oksa

Generate GraphQL queries using Clojure data structures.
Eclipse Public License 2.0
51 stars 1 forks source link

ClojureScript `-name` redef warning #19

Closed BrianChevalier closed 3 months ago

BrianChevalier commented 3 months ago

In a ClojureScript runtime oksa.parse/-name is redefing cljs.core/-name which causes a warning.

Warning message:

------ WARNING #1 - :redef -----------------------------------------------------
 File: ~/.gitlibs/libs/io.github.metosin/oksa/797d7397e09f543c5612613c0bcf5db84a68d877/src/oksa/parse.cljc:286:1
--------------------------------------------------------------------------------
 283 |   [operation-type opts selection-set]
 284 |   [operation-type (or opts {}) (protocol/-form selection-set)])
 285 |
 286 | (declare -name)
-------^------------------------------------------------------------------------
 -name already refers to: cljs.core/-name being replaced by: oksa.parse/-name
--------------------------------------------------------------------------------
 287 |
 288 | (defn -create-operation-definition
 289 |   [type form opts selection-set]
 290 |   (reify
--------------------------------------------------------------------------------
ilmoraunio commented 3 months ago

Thanks for the issue! Was able to reproduce this. I'll make a PR shortly.