metosin / pohjavirta

Fast & Non-blocking Clojure wrapper for Undertow
169 stars 8 forks source link

Websocket support #23

Closed nikolap closed 4 years ago

nikolap commented 4 years ago

Goals with this feature addition. If any are misaligned with the lib, please push back.

1) Allow user to override any of the implementations, e.g. custom listener or callback 2) Attempt to keep API similar (though not identical) to immutant -- should allow for relatively easy plugability with libs like sente 3) Make modular, i.e. so that it can be moved as needed and not directly tied into pohjavirta. The rationale is that many web applications do not require this so it should be an opt-in functionality with custom user-written code to hook it together (perhaps should add helpers?)

Open to feedback and discussion before merging.

Re https://github.com/metosin/pohjavirta/issues/1

ikitommi commented 4 years ago

Looking good, thanks!!