Introduce two-phase Schema compilation - Githubissues

metosin / reitit

A fast data-driven routing library for Clojure/Script

https://cljdoc.org/d/metosin/reitit/

Eclipse Public License 1.0

1.42k stars 254 forks source link

Introduce two-phase Schema compilation #626

Closed ikitommi closed 1 year ago

ikitommi commented 1 year ago

welcome 2-phase schema compilation! Fixes #422.

1) use :update-paths to handle data in certain (loose) paths differently

accumulate schemas in all relevant routers into vector
we do not know the coercion here (ring/http have special handling of data, e.g. http-methods) 2) run coercion compiler for the model to merge the effective model
schema + malli = should work ok, spec = best effort 3) publish final schemas into compiled route data

CHANGELOG

BREAKING: compile-request-coercers returns a map with :data and :coerce instead of plain :coerce function
BREAKING: Parameter and Response schemas are acculated into vector in route data - to be merged properly into compiled result, fixes #422 - merging multiple schemas together works with Malli and Schema, partially with data-spec but not with spec.