Deprecate schema as first argument to walk

metosin / schema-tools

Clojure(Script) tools for Plumatic Schema

http://metosin.github.io/schema-tools/

Eclipse Public License 2.0

107 stars 16 forks source link

Deprecate schema as first argument to walk #24

Closed Deraen closed 8 years ago

Deraen commented 8 years ago

It would make much sense to use same argument order as clojure.walk/walk for schema-tools.walk/walk.

This can be implemented as mostly non-breaking change by adding a test to walk to check for old order.

This has some small(?) performance effect
Some inner and outer arguments aren't necessary fns, but other things which implement IFn, but because map schemas also implement IFn, fn? must be used instead of ifn?

ikitommi commented 8 years ago

LGTM. cljs tests don't pass thou.

Deraen commented 8 years ago

Yes, trying to understand what is breaking the tests.

Deraen commented 8 years ago

Ah, in Cljs the objects and classes are functions. Thus it looks like it's impossible to distinguish between inner, outer and schema if the schema is e.g. s/Str.