Add Context API - Githubissues

metosin / sieppari

Small, fast, and complete interceptor library for Clojure/Script

Eclipse Public License 2.0

207 stars 21 forks source link

Add Context API #31

Closed den1k closed 4 years ago

den1k commented 4 years ago

Inspired by @martinklepsch's #30

adds a context API under sieppari.core/execute-context.
updated sieppari.core/execute to use execute context.
updated tests
added tests for execute-context
- updated readme

Since this is performance critical I reran the performance benchmarks, once before and once after my changes which shows that performance is overall the same. See updated benchmarks below.

den1k commented 4 years ago

@miikka @ikitommi please let me know if anything besides the conflicting README is blocking this PR.

den1k commented 4 years ago

Merged perf regression fixes and reran benchmarks:

https://gist.github.com/den1k/ff82ca3ba7d8dc551de3f4a5fa642849

miikka commented 4 years ago

Tommi will do some perf checks and get back to you.

ikitommi commented 4 years ago

Hi. Run the benchmarks on my local machine. s/execute is ~100% slower when using s/execute-context internally. But it's easy to split the code back to use 2 tracks. Will merge this and fix the perf on top of this. Big thanks for the PR!

ikitommi commented 4 years ago

https://github.com/metosin/sieppari/pull/38