metosin / sieppari

Small, fast, and complete interceptor library for Clojure/Script
Eclipse Public License 2.0
207 stars 21 forks source link

Missing support for SuccessDeferred in manifold AsyncContext #47

Closed dspiteself closed 3 years ago

dspiteself commented 4 years ago

Missing support for SuccessDeferred in manifold AsyncContext. but AsyncContext's Implementation on IDeref prevents a missing implementation error. IDeref's Implementation uses a future. After adding support for SuccessDeferred in manifold AsyncContext the perf test performance is close to promesa. around 7us on my machine https://github.com/metosin/sieppari/pull/46

You may want to include https://github.com/metosin/sieppari/pull/45 to fix missing imports of sieppari.async.manifold in the perf-testing.

Ideally we would add AsyncContext to the interface manifold.deferred.IDeferred so we do not need to support each manifold type.