search

metoule / deezer-control

Google Chrome extension to control music playback on Deezer.com
https://chrome.google.com/webstore/detail/deezer-control/cmkmelneeccijablfclenghkcbopdemg
GNU General Public License v3.0
8 stars 0 forks source link

Deezer Control causing issues with Chrome #3

Closed metoule closed 10 years ago

metoule commented 10 years ago

Original report by Anonymous.

Hello,

I am Erin Tilley, the Global Customer Support Manager at Deezer.

We have noticed an issue with Deezer Control, which is causing issues for users.

Specifically it causes tabs to close automatically in Chrome (Drive, Deezer, Jira, etc). This is obviously impacting us quite heavily and we have had to instruct our staff to uninstall the app.

Here is the configuration of the computers affected:

Would it be possible to get this looked into and resolved?

I am available to discuss this further, should you need and can be contacted at et@deezer.com

Regards, Erin Tilley

metoule commented 10 years ago

Original comment by Métoule (Bitbucket: metoule, GitHub: metoule).

Hi Erin, I'm sorry to hear that!

There's indeed an option in the extension to automatically close a Deezer tab if another is already opened. The way it does that is to match the tab URL via a regular expression; my guess is that the impacted URLs match this regular expression. To be more precise: if the following Javascript expression returns true for the tab's url, then the tab is closed: return new RegExp("^http[s]?:\/\/.deezer.com.","gi").test(iUrl);

A quick workaround would be to disable that option in the extension's option page: go to the 'misc' tab, and chose 'No' for option 'Limit Deezer to one tab', cf screenshot:

Auto close option.png

I'm gonna work on a better fix to ensure the detection is smarter than simply relying on a regular expression, and instead rely on the presence of the actual player.

Feel free to contact me via the email posted on the extension page if you want to discuss this further.

metoule commented 10 years ago

Original comment by Métoule (Bitbucket: metoule, GitHub: metoule).

Version 2.2 is now out, and the Deezer player detection is now more sophisticated than simply checking the URL: the player's existence is checked before closing the new tab.