Closed jhw closed 5 years ago
matthewryanscott
commented
5 years ago I haven't even looked at the code but I already like it based on the description and output file listing! Looking forward to digging in later and helping to push this one through. Let me know if there's anything specific you'd like me to review or help with.
jhw
commented
5 years ago There are a few edge cases the algo is getting wrong - some inaudible patches due to bad module refs it seems - so will likely submit an updated version in a few days. In the meantime you might like to opine on this one
https://github.com/metrasynth/radiant-voices/issues/27
as I it constantly trips me up and I think is probably a flaw. Other than that I will leave it to u as to how you want to refactor and integrate the code. But maybe wait for the update first. Meantime try it and see what u think of the output
On Thu, 28 Feb 2019, 15:58 Matthew R. Scott, notifications@github.com wrote:
I haven't even looked at the code but I already like it based on the description and output file listing! Looking forward to digging in later and helping to push this one through. Let me know if there's anything specific you'd like me to review or help with.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/metrasynth/radiant-voices/pull/28#issuecomment-468327154, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAilB7fspR_vv5UsBgT1oZBINRF2a6oks5vR_yIgaJpZM4bWjXb .
jhw
commented
5 years ago Latest and greatest version (final version for now) -
There are probably a few improvements I could make here and there but this basically does what I want which is to decompile 90%+ of the patches in my favourite tracks, so I'm probably going to leave it there and start doing actual stuff with it now.
Feel free to integrate this the way you want. My main takeaways
Rgds -
python rv/tools/patch_decompiler.py ~/packages/sunvox/examples/NightRadio\ -\ City\ Dreams.sunvox
WARNING - Gen-Loo-Del-Dis/0 is inaudible
WARNING - Gen-Loo-Del-Dis/32 is inaudible
WARNING - Gen-Loo-Del-Dis/64 is inaudible
WARNING - Gen-Loo-Del-Dis/96 is inaudible
WARNING - Gen-LFO-Fla-Ech/1984 is inaudible
WARNING - Gen-LFO-Fla-Ech/2112 is inaudible
INFO - dumping 11 patches [48 versions] to tmp/NightRadio - City DreamsRebased this against latest commit in master.
matthewryanscott
commented
5 years ago There are some build errors that need to be fixed. I'll work on those while I review this.
jhw
commented
5 years ago Any news on this one ?
matthewryanscott
commented
5 years ago I had some personal and work stuff come up, sorry. I'll try to look at this over the coming weekend.
matthewryanscott
commented
5 years ago @jhw finally got a chance to play around with this.
What a brilliant tool! This is sort of thing that I was hoping Radiant Voices would be used for!
Someday, it would be nice to put some more polish onto the Solar Sails project (GUI tools to run alongside SunVox) and include a GUI for this patch decompiler.
I pushed a bunch of code styling, and although in an ideal world I'd like to do a little bit more in terms of adding some docs, I say... SHIP IT! 😄
(In other words, if you are OK with the changes I made, go ahead and merge.)
matthewryanscott
commented
5 years ago A future idea, which we can do in a separate PR... would be to add a --metamodule option to the decompiler so it would output .sunsynth files that had the projects loaded, timeline playback turned on, and TPL/BPM set to whatever the source project was.
matthewryanscott
commented
5 years ago Another thing I noticed (for future ref), is that global commands that happen to repeat are not carried over into the deconstructions. It might be useful to add that functionality in the future.
For example, in one of my tracks I have a global shuffle by affecting the TPL. In the deconstructed version, the rhythms don't sound the same because of the lack of global shuffle.
jhw
commented
5 years ago Glad you like it, yes I think is useful. By all means merge it, I look forward to using the merged version. Yes it could be improved in many ways
On Sun, 17 Mar 2019, 02:28 Matthew R. Scott, notifications@github.com wrote:
@jhw https://github.com/jhw finally got a chance to play around with this.
What a brilliant tool! This is sort of thing that I was hoping Radiant Voices would be used for!
Someday, it would be nice to put some more polish onto the Solar Sails project (GUI tools to run alongside SunVox) and include a GUI for this patch decompiler.
I pushed a bunch of code styling, and although in an ideal world I'd like to do a little bit more in terms of adding some docs, I say... SHIP IT! 😄
(In other words, if you are OK with the changes I made, go ahead and merge.)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/metrasynth/radiant-voices/pull/28#issuecomment-473610071, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAilEvdlk0gbVpzqWmcMvHMH_BmpP4yks5vXahggaJpZM4bWjXb .
jhw
commented
5 years ago I only tested it on the tracks I like :-) so there are probably lots of edge cases such as the one u mention above that are not currently handled. Suggest we create feature branches to fix as we come across them, try add make the tool coverage more compete
On Sun, 17 Mar 2019, 02:41 Matthew R. Scott, notifications@github.com wrote:
Another thing I noticed (for future ref), is that global commands that happen to repeat are not carried over into the deconstructions. It might be useful to add that functionality in the future.
For example, in one of my tracks I have a global shuffle by affecting the TPL. In the deconstructed version, the rhythms don't sound the same because of the lack of global shuffle.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/metrasynth/radiant-voices/pull/28#issuecomment-473610600, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAilMMJRkAvih8P1WTiEaNL8afO1kwkks5vXatNgaJpZM4bWjXb .
So the idea here is to try and "decompile" an existing sunvox project into individual "patches" (like modular synthesis patches). You can then walk the different patches, see which ones you like, re- use/remix them. Not sure where it should go so have stuck in into
tools. Code could probably do with some cleaning up. But a neat idea I think :-) Reminds me of Principal Component Analysis.:-)