metrasynth / radiant-voices

Work with SunVox file format tools (create, modify, read, write)
https://radiant-voices.rtfd.io/
Other
40 stars 3 forks source link

1.0.3 release #60

Closed matthewryanscott closed 3 years ago

matthewryanscott commented 3 years ago

https://www.npmjs.com/package/radiant-voices/v/1.0.3

https://pypi.org/project/radiant-voices/1.0.3/

Fixes #12

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.20%.

Quality metrics Before After Change
Complexity 8.31 ⭐ 8.55 🙂 0.24 👎
Method Length 41.12 ⭐ 41.29 ⭐ 0.17 👎
Working memory 8.61 🙂 8.59 🙂 -0.02 👍
Quality 65.49% 🙂 65.29% 🙂 -0.20% 👎
Other metrics Before After Change
Lines 742 746 4
Changed files Quality Before Quality After Quality Change
setup.py 59.35% 🙂 59.35% 🙂 0.00%
src/python/genrv/init.py 100.00% ⭐ 100.00% ⭐ 0.00%
src/python/rv/init.py 100.00% ⭐ 100.00% ⭐ 0.00%
src/python/rv/project.py 53.13% 🙂 53.21% 🙂 0.08% 👍
src/python/rv/modules/metamodule.py 78.74% ⭐ 78.28% ⭐ -0.46% 👎
src/python/rv/readers/sunvox.py 81.51% ⭐ 80.52% ⭐ -0.99% 👎
src/python/rv/tools/player.py 41.69% 😞 41.80% 😞 0.11% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/python/rv/project.py Project.attach_module.attach_pattern.chunks 20 😞 387 ⛔ 9 🙂 35.39% 😞 Refactor to reduce nesting. Try splitting into smaller methods
src/python/rv/tools/player.py main 13 🙂 291 ⛔ 13 😞 35.94% 😞 Try splitting into smaller methods. Extract out complex expressions
src/python/rv/project.py Project.attach_module.attach_pattern.connect 24 😞 176 😞 10 😞 39.82% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
src/python/rv/project.py Project.attach_module.attach_pattern.chunks.pattern_lines 14 🙂 158 😞 14 😞 42.25% 😞 Try splitting into smaller methods. Extract out complex expressions
src/python/rv/readers/sunvox.py SunVoxReader.process_end_of_file 24 😞 142 😞 8 🙂 47.49% 😞 Refactor to reduce nesting. Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.