search

metrasynth / radiant-voices

Work with SunVox file format tools (create, modify, read, write)
https://radiant-voices.rtfd.io/
Other
40 stars 3 forks source link

Replaces awesome-slugify dependency with python-slugify #61

Closed matthewryanscott closed 3 years ago

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 3.10 ⭐ 3.10 ⭐ 0.00
Method Length 34.22 ⭐ 34.22 ⭐ 0.00
Working memory 8.88 🙂 8.88 🙂 0.00
Quality 77.01% ⭐ 77.01% ⭐ 0.00%
Other metrics Before After Change
Lines 283 283 0
Changed files Quality Before Quality After Quality Change
setup.py 59.35% 🙂 59.35% 🙂 0.00%
src/python/rv/modules/metamodule.py 78.28% ⭐ 78.28% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/python/rv/modules/metamodule.py MetaModule.Mapping.__init__.MappingArray.encoded_values.update_user_defined_controllers.__init__.__getattr__ 9 🙂 68 🙂 12 😞 61.24% 🙂 Extract out complex expressions
src/python/rv/modules/metamodule.py MetaModule.Mapping.__init__.MappingArray.encoded_values.update_user_defined_controllers.__init__.on_controller_changed 4 ⭐ 99 🙂 12 😞 61.53% 🙂 Extract out complex expressions
src/python/rv/modules/metamodule.py MetaModule.Mapping.__init__.MappingArray.encoded_values.update_user_defined_controllers.__init__.__setattr__ 5 ⭐ 65 🙂 11 😞 67.26% 🙂 Extract out complex expressions
src/python/rv/modules/metamodule.py MetaModule.Mapping.__init__.MappingArray.encoded_values.update_user_defined_controllers.__init__.on_controller_changed.on_embedded_controller_changed.specialized_iff_chunks 4 ⭐ 73 🙂 10 😞 68.92% 🙂 Extract out complex expressions
src/python/rv/modules/metamodule.py MetaModule.Mapping.__init__.MappingArray.encoded_values.update_user_defined_controllers.__init__.on_controller_changed.on_embedded_controller_changed.specialized_iff_chunks.load_chunk 4 ⭐ 64 🙂 10 😞 70.30% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.