Sunvox 2.0 file format (Sourcery refactored)

[sourcery-ai[bot]]

Pull Request #71 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will re-run and update (force-push) this Pull Request with new refactorings as necessary. If Sourcery finds no refactorings at any point, this Pull Request will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the sunvox-2.0-file-format branch, then run:

git fetch origin sourcery/sunvox-2.0-file-format
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

[sourcery-ai[bot]]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.15%.

Quality metrics	Before	After	Change
Complexity	7.49 ⭐	7.34 ⭐	-0.15 👍
Method Length	51.00 ⭐	51.00 ⭐	0.00
Working memory	7.00 🙂	7.00 🙂	0.00
Quality	69.80% 🙂	69.95% 🙂	0.15% 👍

Other metrics	Before	After	Change
Lines	411	409	-2

Changed files	Quality Before	Quality After	Quality Change
src/python/rv/tools/patch_decompiler.py	69.80% 🙂	69.95% 🙂	0.15% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
src/python/rv/tools/patch_decompiler.py	ModuleChain.expand.Notes.normalise.Track.split.Tracks.flatten.notefn.module_layout	21 😞	385 ⛔	9 🙂	34.72% 😞	Refactor to reduce nesting. Try splitting into smaller methods
src/python/rv/tools/patch_decompiler.py	ModuleChain.expand.Notes.normalise.Track.split.Tracks.flatten.notefn.decompile	13 🙂	166 😞	11 😞	47.03% 😞	Try splitting into smaller methods. Extract out complex expressions
src/python/rv/tools/patch_decompiler.py	ModuleChain.expand.Notes.normalise.Track.split	12 🙂	108 🙂	11 😞	54.52% 🙂	Extract out complex expressions
src/python/rv/tools/patch_decompiler.py	ModuleChain.expand.Notes.normalise.Track.split.Tracks.flatten.notefn.main	3 ⭐	131 😞	11 😞	60.16% 🙂	Try splitting into smaller methods. Extract out complex expressions
src/python/rv/tools/patch_decompiler.py	ModuleChain.expand	14 🙂	121 😞	6 ⭐	62.11% 🙂	Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!