File link fixes - Githubissues

metricfu / metric_fu

A fist full of code metrics

http://metricfu.github.com/metric_fu

MIT License

627 stars 96 forks source link

File link fixes #248

Closed MGotink closed 9 years ago

MGotink commented 9 years ago

Fix invalid file links for rails best practices
Add file links to cane report
Add file links to saikuro report

I hope removing Template#remove_leading_slash doesn't have any side effects, it was added in 296048fb but I don't see a reason why, no metrics seem to be reporting this way (anymore). All file links in the reports seem to be working fine after removing it.

bf4 commented 9 years ago

I think it's used in the annotated files and how it sets url handlers

MGotink commented 9 years ago

I would expect so, but it seems not necessary (anymore), currently it generates invalid urls to the annotated files in the rails best practices report.

bf4 commented 9 years ago

I haven't run this locally but I trust you to merge if it's good.