search

metricfu / metric_fu

A fist full of code metrics
http://metricfu.github.com/metric_fu
MIT License
627 stars 96 forks source link

Use reek directly #258

Closed MGotink closed 9 years ago

MGotink commented 9 years ago

This contains the commits from and thus closes #255.

MGotink commented 9 years ago

@bf4 can you have a look at it before it's merged?

bf4 commented 9 years ago

will do

bf4 commented 9 years ago

sorry, will do this weekend

MGotink commented 9 years ago

@bf4, ok to merge?

bf4 commented 9 years ago

looking at it now...

bf4 commented 9 years ago

I created a PR in https://github.com/MGotink/metric_fu/pull/1 to fix reek compatibility but I'm not seeing the line numbers in the html reports... is that a regression from https://github.com/metricfu/metric_fu/pull/255 ?

MGotink commented 9 years ago

Thanks!

255 adds line number to the yaml output, not the reports. Which still seems to work correctly.

bf4 commented 9 years ago

I'm here if you want to chat I just invited you to https://gitter.im/metricfu/metric_fu?utm_source=share-link&utm_medium=link&utm_campaign=share-link

bf4 commented 9 years ago

Ok, that's what I thought. Should be good to merge, then.

MGotink commented 9 years ago

Merged, i think this can become 4.12?

bf4 commented 9 years ago

Yup. You good with releasing it?

bf4 commented 9 years ago

Oh, ref: using flay https://github.com/metricfu/metric_fu/pull/231

MGotink commented 9 years ago

Yeah I'm good with releasing it. Was hoping to finish #260 quickly, but it's going to take some more time.