search

metricfu / metric_fu

A fist full of code metrics
http://metricfu.github.com/metric_fu
MIT License
627 stars 96 forks source link

Use verified doubles in specs #260

Closed MGotink closed 9 years ago

MGotink commented 9 years ago

As noted by @bf4 in #258.

bf4 commented 9 years ago

Is missing config in spec_helper

config.mock_with :rspec do |mocks|
    mocks.syntax = :expect
+    mocks.verify_partial_doubles = true
 end
MGotink commented 9 years ago

Hmm, 1.9.2 is failing, no idea why, do we still want to support it?

bf4 commented 9 years ago

It's probably evaling the const before it's defined by the require statement... so, either we can refactor now to use the code from the generator, or just do the release without this then take our time on the refactor

bf4 commented 9 years ago

Since you're doing the work right now, you can decide :)

MGotink commented 9 years ago

@bf4, any ideas for the old reek fix, or just keep it this way for now?

bf4 commented 9 years ago

I suppose this way for now...

B mobile phone

On May 22, 2015, at 2:37 PM, Martin Gotink notifications@github.com wrote:

@bf4, any ideas for the old reek fix, or just keep it this way for now?

— Reply to this email directly or view it on GitHub.

bf4 commented 9 years ago

I just pushed 4.12.0. I couldn't remember my password, so didn't sign it.. will bump a patch if I can remember.