Closed noahsw closed 9 years ago
Sounds good :)
As in you want me to re-organize the README as part of this PR?
On Tue, Aug 11, 2015 at 6:51 AM, Benjamin Fleischer < notifications@github.com> wrote:
Sounds good :)
— Reply to this email directly or view it on GitHub https://github.com/metricfu/metric_fu/pull/264#issuecomment-129880143.
@noahsw I replied by email without seeing the diff, so I thought you were asking for buy-in before making README changes.
Looks good, travis looks weird.. one moment https://travis-ci.org/metricfu/metric_fu/builds/75032732
Ok, travis got turned off someone. dunno. In the meantime, would you mind looking at the failures? Not sure if they're transient. If you'd like I can do it.
1) MetricFu::Configuration for rails_best_practices behaves like configured if #rails? is true should default @rails_best_practices to { :silent => true }
Failure/Error: expect(MetricFu::Metric.get_metric(:rails_best_practices).run_options).to eq(
expected: {:exclude=>[], :silent=>true}
got: {:silent=>true, :exclude=>["config/chef"]}
(compared using ==)
Diff:
@@ -1,3 +1,3 @@
-:exclude => [],
+:exclude => ["config/chef"],
:silent => true,
Shared Example Group: "configured" called from ./spec/metric_fu/metrics/rails_best_practices/configuration_spec.rb:5
# ./spec/metric_fu/metrics/rails_best_practices/configuration_spec.rb:25:i
Fixes #263.
@bf4, I added a code sample to the README. I looked for the best place and concluded this file needs some major reorganization ;-). I'm happy to take a shot but I wanted to share my plan first. I think the H2 Documentation section should include both configuration styles ("Example Configuration"), metric-specific settings (including coverage metrics), formatters, and graph engine.