metricfu / metric_fu

A fist full of code metrics
http://metricfu.github.com/metric_fu
MIT License
627 stars 96 forks source link

Fixed broken dependencies #279

Closed jkeam closed 8 years ago

jkeam commented 8 years ago

Got the build to pass in Travis by including specific gems with specific versions of Ruby. For older versions of Ruby, a lot of these gems simply dropped support.

Also, don't know how to fix VersionEye issues. If a gem simply does not have a license, I have no idea how to figure out what it is or should be.

jkeam commented 8 years ago

Maybe not a hard fail on VersionEye errors? Is there a way to maybe have a warning or something?

bergholdt commented 8 years ago

@jkeam Sorry do not know VersionEye, but why does it not pickup that Rubocop is MIT license?

https://www.versioneye.com/ruby/rubocop/0.42.0 indicate that they have it correctly indexed...could it be caused by the :local_development] ?

jruby-openssl and rb-notifu correctly has no license and terminal-notifier-guard did not have license in 1.53 but later has MIT

jkeam commented 8 years ago

Ya! I wondered that as well. I thought it would at least pick up Rubocop!

bf4 commented 8 years ago

@jkeam @bergholdt I just gave both of you commit. How else can I help?

bergholdt commented 8 years ago

I'm okay with merging this so we can get the travis CI up and running again.

Regarding VersionEye, it looks like you can setup a whitelist of components you don't want to fail you build, but it must be ok for us to look at that after this merge.

jkeam commented 8 years ago

I agree, I'd say let's go ahead and merge this and tackle the version eye issues in another PR.

The VersionEye thing is doing a few wonky things:

  1. rubycop isn't being picked up. The version that fisheye is finding from our gemfile is ":local_development]", which I bet is a parsing error on their part. This is how we are including it: gem "rubocop", platforms: :mri, groups: [:test, :local_development] I bet they are just slicing off the last word, but I haven't checked their code to see what they are actually doing.
  2. jruby-openssl is just not getting picked up for some reason: https://github.com/jruby/jruby-openssl/blob/master/LICENSE.txt
  3. rb-notifu the author has claimed MIT, but hasn't added the LICENSE file yet, so this is a valid error.
  4. terminal-notifier-guard is also not getting picked up: https://github.com/Codaisseur/terminal-notifier-guard/blob/master/LICENSE

But like I said, if there are no objections, I'd love to just merge this PR and get travis working again.

jkeam commented 8 years ago

I'd like to merge this tonight, so if there are no objections, I plan on doing so.

jkeam commented 8 years ago

Beautiful, thanks :)

bf4 commented 8 years ago

Thanks everyone!