search

metricfu / metric_fu

A fist full of code metrics
http://metricfu.github.com/metric_fu
MIT License
624 stars 96 forks source link

WIP Feature/reek extended support #283

Closed bergholdt closed 2 years ago

bergholdt commented 7 years ago

Work In Progress - need tests

This PR makes it possible to use Reek from version 1.3.4 up to current 4.1.0. and fixes Issue #272

I still need to figure out how to make automated test, but I have verified it manually running against metric_fu repo.

I wellcome any help on the test 😊

bf4 commented 7 years ago

When I was last working on MetricFu it was in preparation for a breaking change to solidify the metrics interface so that each metric could be implemented for whatever version of whatever metric gem you want. This is sort of what CodeClimate did with its engines spec, but I never got that far. I bring this up, since you are encountering those same maintenance stresses that got me thinking about how to make maintenance easier. On the plus side, this got me involved in discussions with other projects and thinking more about usability.. but.. might be time for a breaking change

jkeam commented 7 years ago

I think as long as we respect semver, breaking changes are ok :) Esp for something like what you are suggestion. A nice standard interface would be pretty awesome.

mvz commented 7 years ago

Hi, I'm one of the Reek maintainers, and I strongly recommend only supporting Reek 4.x, since that is the first version that follows semver and has a defined API.

mvz commented 7 years ago

Also, if you have any questions, don't hesitate to ask. I would really like to get metric_fu to support an up-to-date version of Reek, since currently it is essentially broken for me. I'd submit a pull request, but it seems there are already two of them outstanding, so I thought I'd first help sort out the versioning issues.

etagwerker commented 4 years ago

@bergholdt Thanks for submitting this! Would it be possible for you to solve the conflicts here?

Travis CI is now passing (✅), so I'd like to see if your changes still work. Also, https://github.com/metricfu/metric_fu/pull/306 will bump the version of reek which might break these changes.

bergholdt commented 4 years ago

@etagwerker merged changes from master - so there is no more conflict. I Admit I have not used metrics_fu for for a long time and do not remember the changes I made on this PR.

Perhaps it would be best to simply close this and create a new that only supports the newest Reek

etagwerker commented 2 years ago

@bergholdt I think that is a good idea. Thank you!