bravier commented 4 years ago

In the exact same way commit 724641e avoided a useless HTTP call on Database.create(exists_ok=True), let's avoid a useless HEAD request on design documents when we're sure we want to get the full document content.

codecov[bot] commented 4 years ago

Codecov Report

Merging #31 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #31   +/-   ##
=======================================
  Coverage   95.92%   95.93%           
=======================================
  Files          11       11           
  Lines         761      762    +1     
=======================================
+ Hits          730      731    +1     
  Misses         31       31

Impacted Files	Coverage Δ
aiocouch/database.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8ba8d96...5d975ac. Read the comment docs.

bravier commented 4 years ago

Hello @bmario! Did you had a chance to look at this PR? I would be happy to have your feedback on it. Thank you.

tilsche commented 4 years ago

Thank you for the PR and the clear description.

metricq / aiocouch

Remove a HTTP call on Database.design_doc(exists_ok=True) #31

Codecov Report