Closed H--o-l closed 3 years ago
Merging #32 (240eb62) into master (510260c) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #32 +/- ##
=======================================
Coverage 95.93% 95.93%
=======================================
Files 11 11
Lines 762 763 +1
=======================================
+ Hits 731 732 +1
Misses 31 31
Impacted Files | Coverage Δ | |
---|---|---|
aiocouch/bulk.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 510260c...240eb62. Read the comment docs.
Thanks @bmario for the quick review and merge! Is it possible for you to upload a new release with this change in a "not to far" future?
Done.
Thanks!
Database.update_docs(ids=[...])
operation was working without crash only if all documents were either modified or created. But if only a subset of documents are really modified inside the bulk operation it crashed with the error:I think it's cool to improve it because: If you have
foo
andbaz
documents in your db, and want to update both, butfoo
already have the update. It's a nice shortcut to update both without having to excludefoo
from the bulk operation (see unit test for an example).