Feature: Python 3.10 support

metricq / metricq-python

🐍 The MetricQ Python interface

https://metricq.github.io/metricq-python/

BSD 3-Clause "New" or "Revised" License

18 stars 7 forks source link

Feature: Python 3.10 support #119

Closed bmario closed 2 years ago

bmario commented 2 years ago

This makes MetricQ ready for python 3.10

Most notably, it refactors the loop parameter out. This part needs careful checking. (Fixes #51)
Adds python 3.10 to test matrix in github actions
Drops support for all Python versions <3.10

bmario commented 2 years ago

Note: This is a breaking change because it removes the event_loop setter.

[x] Update migration documentation to 4.0

bmario commented 2 years ago

I just noticed that the Agent isn't part of the public API, hence, the event_loop shouldn't as well. So... is this even a breaking change then? :thinking:

kinnarr commented 2 years ago

Since we pass the **kwargs to the parent class each time, it is actually public API. Even some of our examples do it this way (https://github.com/metricq/metricq-python/blob/master/examples/metricq_client.py)

bmario commented 2 years ago

Rebased onto master and tested with the watchport source, which seems to work now. @tilsche Any more comments?