search

metricq / metricq-sink-websocket

🕸 A MetricQ sink, which provides live data to consumers over WebSocket connections
GNU General Public License v3.0
2 stars 0 forks source link

Error handling in `websocket_handler` swallows `RPCError`s #12

Open phijor opened 3 years ago

phijor commented 3 years ago

The code here...

https://github.com/metricq/metricq-sink-websocket/blob/1f51f61f07b498364c93c74303cd4619e1527475/metricq_sink_websocket/views.py#L24-L38

...breaks out of the websocket message loop, but does not result in app termination. Exceptions of type RPCError should most likely be fatal.