search

metrics-rs / metrics

A metrics ecosystem for Rust.
MIT License
1.13k stars 158 forks source link

Bring the metrics-observer protobufs up to date #345

Closed ceejbot closed 1 year ago

ceejbot commented 1 year ago

Aligned the proto file in the observer sub-crate with the one in the TCP exporter. Updated the observer message handling code to use the new structures.

This format de-sync will occur again if the writer code is changed without also updating the observer. The right solution here is to have the two crates share the protobuf file, but that requires more structural tinkering than a newcomer like me should do :).

Satisfied the clippy lints complaining about type complexity by creeating some subtypes.

I note that in order to test with rustc 1.56.1, I had to pin the version of mockall used by metrics-util to 0.11.0.

This fixes #325 "metrics-observer is not available".

tobz commented 1 year ago

Released as metrics-exporter-tcp@v0.8.0 and metrics-observer@v0.2.0.

Thanks again for your contribution!