Fix CI - Githubissues

metrics-rs / metrics

A metrics ecosystem for Rust.

MIT License

1.08k stars 148 forks source link

Closed rukai closed 8 months ago

rukai commented 8 months ago

These changes fix CI:

Swapping from cargo install to install-action cuts 45 seconds off the time to run the feature-check workflow.
Changing cargo hack to run as check and --release reduces disk space usage allowing it to complete on the CI runner.
I added #[cfg(feature = "push-gateway")] to avoid triggering a warning for unused import.
netlify needed to install protoc binary and provide path to rust build.

tobz commented 8 months ago

Makes sense to me. 👍🏻

tobz commented 8 months ago

Merged. Thanks for your contribution. 🎉