search

metrics-rs / metrics

A metrics ecosystem for Rust.
MIT License
1.11k stars 156 forks source link

chore/hyper 1.1 upgrade #450

Closed evaneaston closed 6 months ago

evaneaston commented 7 months ago
tobz commented 7 months ago

Oh yeah, this is definitely a meaty one. :)

I would say that we should move the builder code into a new directory (builder) and split the push gateway code and HTTP listener code into their own files, otherwise it starts to get a little crowded.

Once that's sorted, and you've cleaned up some more of the leftover stuff (commented out code, print statements, etc) we can start talking through the actual changes.

evaneaston commented 7 months ago

Sounds like a plan. That's the direction I was going to go. Now to find some more time.

evaneaston commented 7 months ago

@tobz Took a shot at reorganizing the exporters. I removed the nested closures of the http exporter as some might find it easier to read. I need to revisit Cargo.toml.

evaneaston commented 7 months ago

@tobz Would you like me to rebase and --signoff on my stuff. It'll require a diverging force push.

tobz commented 7 months ago

@tobz Would you like me to rebase and --signoff on my stuff. It'll require a diverging force push.

If that's cool with you, that'd be nice. Force pushing is fine.

evaneaston commented 7 months ago

@tobz I pushed the tweak to fix the workflow fail.

tobz commented 6 months ago

@evaneaston Just noticed the merge to get up-to-date with main.

I'll take a final pass shortly and hopefully get this merged today. I think it's close enough that it's good enough to merge, since there's a lot of other changes queued up for release and I'll likely be doing some stylistic cleanup to my own preferences anyways.

tobz commented 6 months ago

Released in metrics-exporter-prometheus@v0.14.0.

Thanks again for your contribution!