search

metrics-rs / metrics

A metrics ecosystem for Rust.
MIT License
1.06k stars 145 forks source link

Remove upper-bound on ahash dependency version #454

Closed AlexandreCassagne closed 4 months ago

AlexandreCassagne commented 4 months ago

Commit f7e979a1b648e0dd8b25ff179c11ce5e15727fcc (fix ahash MSRV nonsense) locks down the version of ahash to <= 0.8.7

This breaks our build alongside actix-web v4.5.1 which calls for ahash 0.8.9.

I can see there are some more recent commits in ahash (main) but I do not understand the underlying issue well enough to determine if the bug was fixed there.

Can you link this issue to a blocking issue on ahash so we can un-pin the dependency again on this repo?

cc @tobz

AlexandreCassagne commented 4 months ago

It looks like this MSRV bump was rolled back in this PR https://github.com/tkaitchuck/aHash/pull/208

tobz commented 4 months ago

Oh neat. If the MSRV bump has been reverted as of ahash 0.8.8, then we can remove the range constraint and instead pin to 0.8.8.

tobz commented 4 months ago

Released in metrics@v0.22.2.

AlexandreCassagne commented 4 months ago

Thanks @tobz.