search

metrics-rs / metrics

A metrics ecosystem for Rust.
MIT License
1.06k stars 145 forks source link

refactor: use hyper-rustls #489

Closed tessus closed 4 weeks ago

tessus commented 1 month ago

From https://github.com/metrics-rs/metrics/pull/420#discussion_r1435328304:

After doing some reading, it seems like we should probably just switch to using rustls entirely.

I don't think the initial implementor choose to use hyper-tls specifically for the OS-backed/dynamically-linked aspect, and I don't personally care about esoteric SSL/TLS setups or FIPS compliance or any of that... so I'd rather go with a single solution than force users to have to spend time understanding which one they ought to choose.

This PR switches to hyper-rustls.

tessus commented 1 month ago

@tobz what do you think?

faultymajority commented 4 weeks ago

Awesome - this also unlocks compiling static binaries on Linux for easy distribution. Is a corresponding release of metrics-exporter-prometheus planned soon?

tobz commented 3 weeks ago

I'm going to try to get this released today.

tobz commented 3 weeks ago

Released in metrics-exporter-prometheus@v0.15.1.

Thanks again for your contribution!

tessus commented 3 weeks ago

Thank you for merging and for the release! Have a great evening.