search

metrics-rs / metrics

A metrics ecosystem for Rust.
MIT License
1.06k stars 145 forks source link

Gigibyte → Gibibyte #497

Open hrxi opened 2 weeks ago

hrxi commented 2 weeks ago

https://github.com/metrics-rs/metrics/blob/f84efc4e0f637c5c1dbbeccb219fe061b3b6cb6b/metrics/src/common.rs#L92

https://en.wikipedia.org/w/index.php?title=Byte&oldid=1227965783#Multiple-byte_units

Seems like a typo, but probably difficult to rectify due to backward compatibility guarantees.

tobz commented 2 weeks ago

Definitely a typo, and we can definitely rectify that.... the power of not being at v1 yet! 😂