metrics20 / spec

39 stars 8 forks source link

Add missing second (s) unit to units table #2

Closed mbbx6spp closed 8 years ago

mbbx6spp commented 9 years ago

There is an implied missing metric unit of seconds when defining the rate metric/target type:

rate: a number per second (implies that unit ends on '/s')

There are also other references to second too. This pull request simple adds the missing unit to the units table in the spec file.

Dieterbe commented 9 years ago

The reason 's' is not in the table is because that table lists the "extension units". SI units (such as 's') are assumed to be part of the spec. But I agree that currently this is not clear at all, and probably confusing.

I propose we add a small table before this table, listing some common/relevant SI units such as s, A and kg, and link to the full SI list. thoughts?

Dieterbe commented 8 years ago

fixed by 2fa3265a7735bcf0590e2121144b8d55d86bab91