search

metriful / sensor

Sensor by Metriful | Indoor environment monitoring | Documentation and code samples
https://www.sensor.metriful.com
MIT License
110 stars 37 forks source link

Make LED_BUILTIN optional #16

Closed hosek closed 1 year ago

hosek commented 3 years ago

Check if LED_BUILTIN is defined, to successfully build with boards without mapping like generic ESP32 Dev module

metriful commented 3 years ago

Thanks, we will make the change for next release. Which ESP32 board are you using?

hosek commented 3 years ago

I'm using FrogBoard, but it doesn't matter, I often select generic ESP32 Dev module + set params like flash size manually. Screenshot 2020-12-17 at 20 34 54

Btw when I was looking into your library, I realised that you are starting Serial console inside library, I think it will be better (more clear) move methods just printing values to console outside of library and have those prints just as separate example how to handle your data classes, or at least mentioned that user can change serial baudrate by redefining SERIAL_BAUD_RATE + mention its default speed in the readme (if its mentioned somewhere, then sorry and nvm)

Overall get rid of dependency on Serial (some boards like Seeduino have more Serials and using some aliases and I think it can make troubles) would be nice. To be not just talking, I can help with that if you want ;) Nice sensor, I really enjoy it!

metriful commented 3 years ago

Thanks for the suggestions about serial. It's difficult to please everyone - many users, especially beginners, want everything hidden as much as possible!

We will review and consider the ideas.