metrixware-echoes-tech / puppet-monit

Puppet module to manage monit installation and configuration
https://forge.puppetlabs.com/echoes/monit
Apache License 2.0
4 stars 48 forks source link

Add support for start delay parameter #10

Closed Caprico85 closed 9 years ago

Caprico85 commented 9 years ago

This PR adds support for the parameter "with start delay x". With this parameter Monit waits x seconds at startup before doing the first checks. Useful to keep Monit from reporting or restarting servives that take longer to start after a reboot.

FlorentPoinsaut commented 9 years ago

Hi,

Thank you for your PR. I work with Monit 5 and I don't find this option in the official documentation (https://mmonit.com/monit/documentation/monit.html#DAEMON-MODE) nor in the man. I just find an online man (http://linux.die.net/man/1/monit) that explains it. Is it an option only present in Monit 4 ? If yes, could you add a condition about the version to enable or not this option ?

Thanks a lot in advance. Regards,

Caprico85 commented 9 years ago

Hi,

yes, with start delay seems to not have been documented anywhere except on that online man page.

According to the changelog this option was added with Monit 5.0. I am using it here since Monit 5.9 and currently on 5.14 without problems.

Regards, Caprico

FlorentPoinsaut commented 9 years ago

Ok, thank you for your investigation. So, could you add a condition to enable this option only for Monit 5 ?

Thanks a lot in advance. Regards,

Caprico85 commented 9 years ago

Of course. I changed my PR so that Puppet fails with an error message if you try to set start_delay on Monit < 5.