search

metrixware-echoes-tech / puppet-monit

Puppet module to manage monit installation and configuration
https://forge.puppetlabs.com/echoes/monit
Apache License 2.0
4 stars 48 forks source link

Added configuration option to set an M/Monit report server in Monit config file #11

Closed xnicolovici closed 9 years ago

xnicolovici commented 9 years ago

Added in the sametime support for CentOS 7 (config file is /etc/monitrc, not /etc/monit.conf)

FlorentPoinsaut commented 9 years ago

Hi,

Thank you for your PR. Apparently, this set of options works fine with Monit 5 but does not exist in Monit 4. Could you add documentation and a condition or a exception about the version to enable or not these options ?

Thanks a lot in advance. Regards,

xnicolovici commented 9 years ago

Hi,

Thanks for the feedback. As I'm not using any Monit agent release 4, I was not aware of that. So, I've added a check on the use of the $mmonit_* options and the release of Monit agent. If it's not compatible, then the module will fail:

fail('M/Monit option (via mmonit_* parameters needs Monit agent >= 5')

A warning has been added in the module doc:

WARNING: If this option is set, and Monit agent version is less than 5, then module will fail (this option is available in Monit Agent version 5 and above.

FlorentPoinsaut commented 9 years ago

Hi,

Thank you for your fork of my module (https://github.com/echoes-tech/puppet-monit). I merged your work on my own branch.

Thanks a lot for your contribution.

Regards,