search

metrixware-echoes-tech / puppet-monit

Puppet module to manage monit installation and configuration
https://forge.puppetlabs.com/echoes/monit
Apache License 2.0
4 stars 48 forks source link

Add tests #20

Closed ghoneycutt closed 8 years ago

ghoneycutt commented 8 years ago

Noticed there are some comments about needing to document things. Please hold off on merge until that's done.

ghoneycutt commented 8 years ago

@echoes-tech @floSoX

We've updated the tests and docs and are now ready for merge.

Thanks!

FlorentPoinsaut commented 8 years ago

Hello,

Thank you for your explanations and one more time for your hard work. You wrote :

I'm still against inheriting the ::params class though, as the only reason to ever use inheritance is when you want to override a resource. This is to satisfy DRY, instead of repeating the resource in another class.

That exactly my need since I use this module through an ENC. I cannot merge your PR easily it would break my integration. Moreover this code architecture is mandatory, it is a convention within my company.

To reduce the work to merge your job, can you put back the params.pp file and I will split the remaining files right after.

Thanks in advance,

ghoneycutt commented 8 years ago

Hi @floSoX I've run out of budget and time to continue working on this :(

I hope you find it useful and perhaps refactoring to fit your needs will be worth doing, given all the added spec testing.

Best regards, -g

ghoneycutt commented 8 years ago

@petems and anyone else following. I forked this repo and released v1.0.0 which is compatible with this repo's v1.0.0, so you can port modules without worry.

https://github.com/ghoneycutt/puppet-module-monit/tree/v1.0.0

FlorentPoinsaut commented 8 years ago

Hi @ghoneycutt !

I finally took time to merge your great work to my develop branch.

Please, accept my apologies for the long delay before this merge.

I will release the v1.1.0 very soon.

Thank you very much for your hard work!