search

metrixware-echoes-tech / puppet-monit

Puppet module to manage monit installation and configuration
https://forge.puppetlabs.com/echoes/monit
Apache License 2.0
4 stars 48 forks source link

Redesign from a previously forked module #26

Closed ghoneycutt closed 8 years ago

ghoneycutt commented 8 years ago

https://github.com/ghoneycutt/puppet-module-monit

ghoneycutt commented 8 years ago

Hi @floSoX

Saw that you merged my tests from PR #20 and thought I would offer you this PR. As I was using this module for a client that demanded different coding standards, namely spec tests and not using private classes, I went ahead and forked your module to https://github.com/ghoneycutt/puppet-module-monit

This PR is a way for you to get in all of those changes, which at this point just boil down to not using the private classes such as ::install, ::config, ::service and ::params. I would be happy to not have to maintain my fork and have these pulled in by you.

If you are interested I'll clean up the README a bit before this is merged.

FlorentPoinsaut commented 8 years ago

Hi @ghoneycutt,

Thank you for this PR and, one more time, for your previous work. You can see that I included the maximum of your modifications (namely spec tests). However, I can't merge it. As I explained, I also have my client constraints (and the private classes is one of these).

Regards,