metrixware-echoes-tech / puppet-monit

Puppet module to manage monit installation and configuration
https://forge.puppetlabs.com/echoes/monit
Apache License 2.0
4 stars 48 forks source link

handle puppet strict_variables #27

Closed saimonn closed 7 years ago

saimonn commented 7 years ago

The precedent version fails with strict_variables enabled on the puppetserver side.

FlorentPoinsaut commented 7 years ago

Hi @saimonn,

Thank you for your contribution. I have a question. When I read the doc: https://docs.puppet.com/puppet/latest/reference/function.html#defined I read this:

This function takes at least one string argument, which can be a class name, type name, resource reference, or variable reference of the form '$name'.

Should it not be: defined('$::monit_version')?

Regards,

saimonn commented 7 years ago

You are right, I've amended the commit in this way.