search

metrixware-echoes-tech / puppet-monit

Puppet module to manage monit installation and configuration
https://forge.puppetlabs.com/echoes/monit
Apache License 2.0
4 stars 47 forks source link

add support for mmonit https addresses #30

Open SyBernot opened 7 years ago

SyBernot commented 7 years ago

Our mmonit uses https, looking at the template http is hardcoded, you could create a toggle for http/https but all the mmonit vars are only used in this one place might I suggest just using a $mmonit_connect_string instead of trying to assemble it, it makes the template more flexible and less error prone.

$mmonit_connect_string =>'https://foo:bar@baz.com:8083/collector',

set mmonit <%= @mmonit_connect_string %>

also having an additional config variable stuffed in the template would prove useful $mmonit_extra_config => ['check process apache with pidfile /usr/local/apache/logs/httpd.pid', ' start program = "/etc/init.d/httpd start"'],

<% mmonit_extra_config.each do |line| %> <%= line %> <% end %>

FlorentPoinsaut commented 7 years ago

Hi!

Thank you for your suggestion. Could you please make a PR with your modifications? Then I would be pleased to integrate it.

Thank you in advance.

Regards,

nospoe commented 5 years ago

Hi,

I see still no updates since April. If you grant me permissions to push a branch to the repo and create a PR I could add the $mmonit_connect_string as I am in great need of it.

Or maybe add an extra parameter like $mmonit_address_https and another if statement in monitrc template.

Regards, George

FlorentPoinsaut commented 5 years ago

Hi, This repository is no longer maintained. You can find a new compatible module with HTTPs for M/Monit here: https://forge.puppet.com/soli/monit Regards,