search

metroid-maniac / gba-auto-batteryless-patcher

MIT License
76 stars 4 forks source link

Missing write function signatures #3

Open metroid-maniac opened 1 year ago

metroid-maniac commented 1 year ago

Some function signatures for SRAM writes seem to not yet be detected by the patcher like Pokemon and Final Fantasy Tactics Advance. Support for the function signatures in these games will need to be added.

metroid-maniac commented 1 year ago

Write signature for Pokemon Ruby has now been added, unknown if others needed?

metroid-maniac commented 1 year ago

Looks like Rhythm Tengoku uses a variant that runs in RAM, will need to patch this one too. Containing function is at 4c8b0

EDIT: looks like the function at that address is a better target, currently the signature is for the subroutine that runs from RAM

metroid-maniac commented 1 year ago

Tony Hawk Pro Skater 2 reported not working (EEPROM_V111)

Quickfixed.

metroid-maniac commented 1 year ago

The save hook does not trigger in Yu-Gi-Oh! Reshef of Destruction.

metroid-maniac commented 1 year ago

For some reason, the exact same write function is repeated twice consecutively at 58760 and 587a0 in Yu-Gi-Oh! Reshef of Destruction. The patcher only catches the first one right now.

metroid-maniac commented 1 year ago

Yu-Gi-Oh Reshef and Castlevania Double Pack should be fixed with 1a27162.