search

metroline / metroline-ui

UI of Metroline, an Open Source Continuous and Delivery Platform (CICD) built with Docker, Node, React, MongoDB, Socket.io and D3 and Typescript.
GNU General Public License v3.0
0 stars 2 forks source link

"No repos" repo empty list placeholder not the same when signed in and signed out #1

Closed gempain closed 4 years ago

gempain commented 4 years ago

When you not signed in, the home page shows "No repos". When you are signed in and you have no repos, the empty list looks different. We should use the <EmptyList/> component here:

https://github.com/metroline/metroline-ui/blob/b43dfe2cadeeb3d9601d31a9c4b3d48c890659e4/src/components/repos/RepoList.tsx#L65

just like we do here:

https://github.com/metroline/metroline-ui/blob/b43dfe2cadeeb3d9601d31a9c4b3d48c890659e4/src/components/repos/RepoList.tsx#L70

Create a const with the empty list and use it in both places.

gempain commented 4 years ago

Released in v1.0.2