fix: remove view listing button from closed listings - Githubissues

metrotranscom / doorway

component-based web framework for affordable housing management

Apache License 2.0

3 stars 1 forks source link

fix: remove view listing button from closed listings #710

Closed KrissDrawing closed 6 days ago

KrissDrawing commented 1 week ago

This PR addresses #704

[x] Addresses the issue in full
[ ] Addresses only certain aspects of the issue

Description

Hides "view application" button on /account/applications when listing is closed.

How Can This Be Tested/Reviewed?

File application, it should show view application button on /account/applications. Close listing, the button should be hidden.

Author Checklist:

[ ] Added QA notes to the issue with applicable URLs
[x] Reviewed in a desktop view
[x] Reviewed in a mobile view
[ ] Reviewed considering accessibility
[x] Added tests covering the changes
[ ] Made corresponding changes to the documentation
[ ] Ran yarn generate:client and/or created a migration when required

Review Process:

Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates