search

metrue / fx

A Function as a Service tool makes a function as a container-based service in seconds.
MIT License
2.16k stars 155 forks source link

delete minor unreachable code caused by log.Fatal #664

Closed Abirdcfly closed 2 years ago

Abirdcfly commented 2 years ago

Signed-off-by: Abirdcfly fp544037857@gmail.com

Issue: Summary: https://pkg.go.dev/log#Fatalf

Fatalf is equivalent to Printf() followed by a call to os.Exit(1).

The checklist before PR is ready for review:

codecov[bot] commented 2 years ago

Codecov Report

Merging #664 (9e17944) into master (0d278f8) will decrease coverage by 0.66%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #664      +/-   ##
==========================================
- Coverage   24.96%   24.29%   -0.67%     
==========================================
  Files          55       55              
  Lines        1951     1951              
==========================================
- Hits          487      474      -13     
- Misses       1383     1401      +18     
+ Partials       81       76       -5
Impacted Files Coverage Δ
container_runtimes/docker/sdk/docker.go 35.50% <0.00%> (-9.43%) :arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more