search

metrumresearchgroup / bbi

Next generation modeling platform
11 stars 2 forks source link

summary: account for chain method in incomplete run check #289

Closed kyleam closed 1 year ago

kyleam commented 1 year ago

As of the last release (specifically 7c0caa76), GetModelOutput() compares the lengths of RunDetails.EstimationMethods and of the ParseParamsExt() return value, and errors if they don't match. The intent is to catch incomplete runs, but this check is incorrectly triggered for METHOD=CHAIN because that method does not have corresponding estimation data.

Update the check so that the chain method is not counted toward the expected length. Based on the NONMEM help, it appears that all other method types should have corresponding estimation values.

Closes #288.

I don't think any adjustments are needed on the bbr side. Using the same model from which the test data here was derived, I confirmed that, following this bbi change, I can call model_summary with no errors.

cc @kylebaron

kyleam commented 1 year ago

Drone has some failures.

https://github-drone.metrumrg.com/metrumresearchgroup/bbi/954/2/6

Edit: At first glance, none of them look related to summary. I will push a scratch branch with mains tree to confirm.

https://github-drone.metrumrg.com/metrumresearchgroup/bbi/955