metrumresearchgroup / bbi

Next generation modeling platform
11 stars 2 forks source link

integration: test period_test scenario #308

Closed kyleam closed 9 months ago

kyleam commented 9 months ago

As of aa686d3 (tests: removing more scenarios from tests that don't need so many divergent paths [...], 2021-09-23), the period_test scenario is no longer used by any tests. This scenario provides a regression test for a fix in v2.3.1, so it's worth keeping around.

Restore its use in TestBbiCompletesLocalExecution.

kyleam commented 9 months ago

This is ready to review but should be merged after its base (gh-307).

kyleam commented 9 months ago

The integration tests for this branch took about 20 minutes. The base run took around 12 minutes, which makes me worried this is adding a bit of time. However...

So my current guess is that the timing variability above is due to something other than this PR's additional scenario (e.g., the runner being primed for SGE).

kyleam commented 9 months ago

I was thinking the same thing [...]

Thanks for your input here (and good point about the difference between the companion builds).