metrumresearchgroup / bbr.bayes

Bayesian modeling with BBR
https://metrumresearchgroup.github.io/bbr.bayes/
Other
5 stars 1 forks source link

add nm_join_bayes #106

Closed kyleam closed 1 year ago

kyleam commented 1 year ago

When working on run_sims in gh-75, we decided to focus on the return value and rename the function to nm_join_bayes, treating it as the nmbayes analog of nm_join. Going that direction led to gh-96, and consensus from discussion there was that 1) we should try to align with nm_join as closely as possible (e.g., support .files) and 2) ideally nm_join would be used underneath to avoid repeating some its more complicated logic.

This series implements that proposal and supersedes gh-75. Most notable changes from gh-75:

Closes #46. Closes #50. Closes #96. Closes #100.

Re: #97

cc: @kylebaron @timwaterhouse


kyleam commented 1 year ago

@seth127 Thanks for the review. Pushed updates. Back to you.