metrumresearchgroup / bbr.bayes

Bayesian modeling with BBR
https://metrumresearchgroup.github.io/bbr.bayes/
Other
5 stars 1 forks source link

Start depending on `etasrc` #117

Closed kylebaron closed 10 months ago

kylebaron commented 11 months ago

Following #115 and #116 ...

We are still depending on having all ETAs declared as parameters in the model when doing the ipred simulation.

But I think we can (should) switch to using the etasrc argument to manage this. If we make this change, then we won't have to validate that there are ETA parameters in the model to pick up this information from the data (mrgsolve will take care of it automatically).

I think it still makes sense to purge ETAn from the data set just in case there is this logic written into the model.

This will require minimum mrgsolve version of 1.0.8.