search

metrumresearchgroup / bbr

R interface for model and project management
https://metrumresearchgroup.github.io/bbr/
Other
23 stars 2 forks source link

fix per Kyle Baron's suggestion #466

Closed barrettk closed 2 years ago

barrettk commented 2 years ago

Reference Issue: https://github.com/metrumresearchgroup/bbr/issues/465

Fix includes grep-ing out "TAB" instead of matching "TABLE"

barrettk commented 2 years ago

Conversation with KyleB pasted below for convenience:

Hey Kyle, do you have any time today or next week to go over this issue? If I understand correctly, I believe this will be a simple fix. Seems like you're suggesting some of the names could be "TAB" rather than "TABLE", which would be missed by the call you mentioned.

Yeah; same with EST and ESTIMATION … nonmem does partial matching and people use both.

does bbr have an issue with EST vs ESTIMATION as well?

It might not be looking there.

barrettk commented 2 years ago

Last commit addressed issue https://github.com/metrumresearchgroup/bbr/issues/467