check_run_times: handle BBI_NULL_NUM special case?

metrumresearchgroup / bbr

R interface for model and project management

https://metrumresearchgroup.github.io/bbr/

Other

23 stars 2 forks source link

check_run_times: handle BBI_NULL_NUM special case? #518

Closed kyleam closed 2 years ago

kyleam commented 2 years ago

It's possible for the value of the postprocess_time or cpu_time field to come through as BBI_NULL_NUM if no values are parsed from the model output. Should check_run_times catch this special case and convert it into something a little more obvious to the user (perhaps NA_real_)?

https://github.com/metrumresearchgroup/bbr/blob/f31d080e8e5fba97956fe0b1d4b8a69f1f8ec22d/R/test-threads.R#L212-L213

cc: @barrettk

barrettk commented 2 years ago

tbh im not sure what's desired. I would vote to get a scientists opinion on this.

@kylebaron, @callistosp do you guys have any thoughts?

For reference:

> BBI_NULL_NUM
[1] -1e+09

barrettk commented 2 years ago

@kyleam btw im not able to load that link you attached:

kyleam commented 2 years ago

@kyleam btw im not able to load that link you attached:

Ah, thanks. That was derived from an unpushed commit. Updated to be based off main.

kyleam commented 2 years ago

https://github.com/metrumresearchgroup/bbr/issues/520 proposes doing this replacement tree-wide, so this could potentially be rolled up into that.