search

metrumresearchgroup / bbr

R interface for model and project management
https://metrumresearchgroup.github.io/bbr/
Other
23 stars 2 forks source link

Printing of duplicate rows in nm_join is excessive #536

Closed barrettk closed 2 years ago

barrettk commented 2 years ago

After merging https://github.com/metrumresearchgroup/bbr/pull/533, @kylebaron pointed out that printing the duplicate rows could be a bit excessive in the case of 1000's of duplicates: image

Additionally, it would make sense to update the docs and inform users of how duplicate rows are actually handled: image

Small adjustment, but while we're at it we might as well make this code more legible: image

rymarinelli commented 2 years ago

@barrettk I'm not sure if we want to remove the duplicated column. I think that could disrupt the ordering of the rest of the columns. It might be better to have the end user re-specify the ordering they want to use.

barrettk commented 2 years ago

@rymarinelli this is for duplicate rows, not columns. In this case we just want to remove the printing of the duplicate rows