Closed kyleam closed 2 years ago
Maybe print a newline between each arg to make it easier to read.
I played around with a newline a bit and then settled on trying to make the different entries stand out by bolding the argument name and indenting subsequent lines. The main advantage I saw in avoiding the newline was preserving vertical screen real estate.
But that assumes the bolding works well to distinguish, and perhaps it didn't because...
Or (maybe instead of, maybe in addition to ^) make the name of the argument bold or something
... you suggest bolding next. You're talking about the first word of the entry, right? That doesn't appear bold on your end?
Should we consider exporting the BBI_ARGS constant [...]
Yeah, I like that idea. The only thing I wonder is whether we should make clear that we're not committing to the structure/values. Don't know if that's worth worrying about.
I asked:
That doesn't appear bold on your end?
Hmm, perhaps it's an rstudio server thing. If I try that with rstudio server, things look remarkably unbold:
Before submitting this PR, I tested it out on rstudio desktop, my editor, and the plain terminal. It looks bold in all of those:
If cli::style_bold()
doesn't play well with rstudio server, I guess the best option is probably to switch to using a color.
If cli::style_bold() doesn't play well with rstudio server, [...]
By the way, my guess is that it is bolded, it's just very unimpressive bolding.
Pushed an update to
BBI_ARGS
and point to View(bbr::BBI_ARGS)
alternative in print_bbi_args()
docsI've rebased this on top of the current main due to the bbi drone update.
This PR started with me just wanting to update
BBI_ARGS
for recent changes in bbi, in particular https://github.com/metrumresearchgroup/bbi/pull/279 and https://github.com/metrumresearchgroup/bbi/pull/280. This was the first time I looked closely at the.bbi_args
handling andprint_bbi_args
, and I'm a bit confused by it and think it might make sense to rework things. But I still don't really have a clear picture (and maybe my impression is off the mark), so this series doesn't make any of those sorts of changes.In addition to updating the option list, it
print_bbi_args
output to (hopefully) be a bit easier to digest, including trying to make nmfe options stand outExample of new output: