metrumresearchgroup / bbr

R interface for model and project management
https://metrumresearchgroup.github.io/bbr/
Other
23 stars 2 forks source link

Prepare for bbr.bayes package #543

Closed kyleam closed 1 year ago

kyleam commented 2 years ago

The plan is to split the bbr_stan_alpha functionality (#358) into its own packages. That, however, requires some changes on bbr's side. This PR uses bbr_stan_alpha as the base (and includes all the commits in that PR ~except for the last one, which is just a DESCRIPTION change~). The commits on top of bbr_stan_alpha remove the parts that are headed to the dedicated package, and add and expose functionality for that package to hook into (e.g., new generics).

Note that, in addition to "separate package support" changes, this PR would bring in the submit_mode(..., .overwrite = ...) change from the bbr_stan_alpha branch (mostly from commit 1c44d1c). This came in separately in https://github.com/metrumresearchgroup/bbr/pull/547

I'm marking this as a draft because see March 9 update below

cc @seth127

Update 2023-03-09: Anticipating a bbr.bayes release in the next 1-2 months, so this will be reviewed, merged, and released in the near future.

kyleam commented 1 year ago

Merged in main to resolve conflicts with 1.5.0 release. Left DESCRIPTION version at 1.5.0, but we can bump to dev version and tag whenever we need a new dev release for bbr.bayes.

kyleam commented 1 year ago

Forge ahead!

All right, in it goes. Thanks for the review.