search

metrumresearchgroup / bbr

R interface for model and project management
https://metrumresearchgroup.github.io/bbr/
Other
23 stars 2 forks source link

Match order of stories to previous release #551

Closed barrettk closed 2 years ago

barrettk commented 2 years ago

After sending the bbr 1.4.0 validation docs to Aing, we found that the previous order of stories (i.e. story ID's) must be consistent across previous releases as well.

In this PR:

The validation docs have already been regenerated and forwarded to Aing based on this change

kyleam commented 2 years ago

Ah, so this came from you changing the story ID in eace5331 (additional changes to stories ..., 2022-08-16)? I should have caught that when reviewing gh-535. Makes sense, we talked about changing requirement IDs (because those were new to 1.4.0), but a story ID shouldn't have been changed.

seth127 commented 2 years ago

Just for posterity's sake: Aing wasn't concerned with changes to Requirement IDs or Test IDs across releases. She just wanted Story IDs to stay consistent because those are essentially the top-level definition of "what the product does" as far as validation is concerned, so she tracks which stories are added or removed from release to release.

kyleam commented 2 years ago

She just wanted Story IDs to stay consistent

@seth127, that's good to know, but either way, from our perspective, we want all of these IDs to stay stable (stories, reqs, and tests) once they make it into a release, right? https://github.com/metrumresearchgroup/bbr/pull/535#issuecomment-1219754770

seth127 commented 2 years ago

we want all of these IDs to stay stable (stories, reqs, and tests) once they make it into a release, right?

Yes, that's right. I just wanted to note that if we need to change other ones (I'm mainly thinking of test IDs changing if/when we refactor the test suite) that it's not a big deal.